Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete all threads #4446

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

bxdoan
Copy link
Contributor

@bxdoan bxdoan commented Jan 14, 2025

Describe Your Changes

Add a "Delete All Threads" button in the advanced settings

delete1

Clear warning that this action cannot be undone and will remove all conversation threads in file_path, Delete (red) and Cancel buttons for confirmation

delete2

Result information on top right app

delete3

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan
Copy link
Contributor

Hi @bxdoan, this PR looks good. Please fix all linter issues so we can proceed. CC @imtuyethan for the wording check.

@bxdoan
Copy link
Contributor Author

bxdoan commented Jan 14, 2025

Linter is good now, bro @louis-jan

@louis-jan
Copy link
Contributor

louis-jan commented Jan 14, 2025

@bxdoan Cool! @imtuyethan has a couple feedbacks on the component position and wording. Will leave a comment soon.

@louis-jan louis-jan self-requested a review January 14, 2025 12:24
@imtuyethan
Copy link
Contributor

imtuyethan commented Jan 14, 2025

@bxdoan
Screenshot 2025-01-14 at 7 33 12 PM

Thanks for the PR! Please help me change the order of the Factory Reset settings to the end of the page, everything else looks good!

@louis-jan louis-jan changed the title Feature delete all threads feat: delete all threads Jan 14, 2025
@bxdoan
Copy link
Contributor Author

bxdoan commented Jan 15, 2025

@imtuyethan I updated to position of "Delete all threads"

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's goooo!!!

@louis-jan
Copy link
Contributor

I believe there's a permission issue, which is why CI failed. Will proceed for a merge.

@louis-jan louis-jan merged commit ffec1cf into janhq:dev Jan 15, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants