-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete all threads #4446
feat: delete all threads #4446
Conversation
Hi @bxdoan, this PR looks good. Please fix all linter issues so we can proceed. CC @imtuyethan for the wording check. |
Linter is good now, bro @louis-jan |
@bxdoan Cool! @imtuyethan has a couple feedbacks on the component position and wording. Will leave a comment soon. |
Thanks for the PR! Please help me change the order of the Factory Reset settings to the end of the page, everything else looks good! |
@imtuyethan I updated to position of "Delete all threads" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Let's goooo!!!
I believe there's a permission issue, which is why CI failed. Will proceed for a merge. |
Describe Your Changes
idea: Add "Delete All Threads" functionality #4396
Add a "Delete All Threads" button in the advanced settings
Clear warning that this action cannot be undone and will remove all conversation threads in
file_path
, Delete (red) and Cancel buttons for confirmationResult information on top right app
Self Checklist